Sandbox: Cleanup shim on Start failure #8255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a change a bit ago to cleanup the shim on CreateSandbox failures and noted that we should probably do the same on Start as well as nothing gets cleaned up otherwise, and nothing states that a sandbox server/shim should exit itself if Create/Start fail. Ideally this could be hooked up to some subsystem in containerd that'd do it for us, but for now to allow developing prototyping sandbox shims this makes things much friendlier. Signed-off-by: Danny Canter <danny@dcantah.dev>
dcantah
commented
Mar 13, 2023
| Error("failed to shutdown sandbox") | ||
| } | ||
|
|
||
| ctx, cancel := context.WithTimeout(ctx, 5*time.Second) |
|
Interesting, the k8s flows failed the millisecond I opened this and won't let me click on them to view the status 😭 |
dmcgowan
approved these changes
Mar 15, 2023
|
/retest |
|
@dcantah prow jobs were having some issues yesterday, lets see if they do better today |
dcantah
added
the
cherry-pick/1.7.x
|
/retest |
kzys
approved these changes
Mar 15, 2023
estesp
approved these changes
Mar 15, 2023
dmcgowan
added
cherry-picked/1.7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a change a bit ago to cleanup the shim on CreateSandbox failures and noted that we should probably do the same on Start as well as nothing gets cleaned up otherwise, and nothing states that a sandbox server/shim should exit itself if Create/Start fail. Ideally this could be hooked up to some subsystem in containerd that'd do it for us, but for now to allow developing/prototyping sandbox shims this makes things much friendlier.