[release/1.7 backport] Migrate reference/docker package to github.com/distribution/reference #10316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference/docker package was a fork of github.com/distribution/distribution, which could not easily be used as a direct dependency, as it brought many other dependencies with it. The "reference' package has now moved to a separate repository, which means we can replace the local fork, and use the upstream implementation again. The new module was extracted from the distribution repository at commit: distribution/distribution@b9b1940 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 4923470) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This function is deprecated in distribution/reference, and removed in distribution/reference v0.6; reference.Domain or reference.Path should be used instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
1.7_backport_replace_reference
branch
from
8fccac0 to
783f248
Compare
thaJeztah
commented
Jun 8, 2024
Comment on lines
131
to
140
| // SplitHostname splits a named reference into a | ||
| // hostname and name string. If no valid hostname is | ||
| // found, the hostname is empty and the full value | ||
| // is returned as name | ||
| // | ||
| // Deprecated: Use [reference.Domain] or [reference.Path]. | ||
| func SplitHostname(named reference.Named) (string, string) { | ||
| return reference.SplitHostname(named) | ||
| } | ||
|
|
There was a problem hiding this comment.
This was depreciated, and removed in upstream, so had to remove the alias
Bumps [github.com/distribution/reference](https://github.com/distribution/reference) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/distribution/reference/releases) - [Commits](distribution/reference@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: github.com/distribution/reference dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 362fcf2) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
1.7_backport_replace_reference
branch
from
783f248 to
97abbe9
Compare
dmcgowan
approved these changes
Jun 10, 2024
|
@AkihiroSuda ptal 🤗 |
AkihiroSuda
approved these changes
Jun 11, 2024
thaJeztah
changed the title
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport:
The reference/docker package was a fork of github.com/distribution/distribution, which could not easily be used as a direct dependency, as it brought many other dependencies with it.
The "reference' package has now moved to a separate repository, which means we can replace the local fork, and use the upstream implementation again.
The "reference" package was moved to a separate module, which was extracted from distribution/distribution@b9b1940