Update read_line behaviour to read_line_initial_text #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`term.read_line()` is not using the declared term to request the input. It relies on stdin.
This is not the case of `term.read_line_initial_text("")`, which reads key one by one using `self.read_key()`.
This commits corrects this behaviour, and removes divergence between the two methods.
|
@mitsuhiko tagging you for review as you've been the last one to merge changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
term.read_line()is not using the declared term to request the input. It relies on stdin. This is not the case ofterm.read_line_initial_text(""), which reads key one by one usingself.read_key().This commits corrects this behaviour, and removes divergence between the two methods.
If
read_lineandread_line_initial_textare meant to have a different behaviour, their documentation needs to be updated. I'd be glad to update this PR if that's the case.