Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #13975 #14065

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Revert #13975 #14065

merged 4 commits into from
Jul 24, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jul 23, 2024

Description

Reverts #13975 after concerns raised in #12558 (comment).

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@jaimergp jaimergp requested a review from a team as a code owner July 23, 2024 15:45
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 23, 2024
@jaimergp jaimergp changed the base branch from main to 24.7.x July 23, 2024 15:45
news/14065-revert-13975 Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #14065 will improve performances by ×6.2

Comparing jaimergp:revert-13975 (8fa068c) with 24.7.x (d486f89)

Summary

⚡ 7 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark 24.7.x jaimergp:revert-13975 Change
test_env_create[libmamba] 4,743.2 ms 794.7 ms ×6
test_env_update[libmamba] 9.6 s 1.6 s ×6
test_install[libmamba] 9.6 s 1.6 s ×6.2
test_list[libmamba] 4,877.5 ms 875.4 ms ×5.6
test_run[libmamba] 4,908.3 ms 908.5 ms ×5.4
test_update[libmamba-update] 9.6 s 1.6 s ×5.9
test_update[libmamba-upgrade] 9.6 s 1.6 s ×5.9

@kenodegard kenodegard mentioned this pull request Jul 23, 2024
61 tasks
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
kenodegard
kenodegard previously approved these changes Jul 23, 2024
@kenodegard kenodegard enabled auto-merge (squash) July 23, 2024 16:05
@jaimergp
Copy link
Contributor Author

Those benchmarks 🚀 hahah

beeankha
beeankha previously approved these changes Jul 23, 2024
@mbargull
Copy link
Member

@jezdez pointed out in #12558 (comment) that my feedback is too late in the release process (with which I agree).
I don't know the formalities of the process and as such can't gauge what's more adequate between blocking an in-process release vs putting out a hot fix release after (neither is ideal, of course).
I agree with this feedback:

I’d suggest to work on an improved patch that only presents users with a note that future versions of conda will change env name handling.

@mbargull
Copy link
Member

@jezdez suggested to put out a warning that we'll reiterate on this in the future.
I've pushed #14073 as a suggestion to give a rough idea on how we could do that.

@kenodegard kenodegard dismissed stale reviews from beeankha and themself via 8fa068c July 24, 2024 19:45
@kenodegard kenodegard merged commit 188c56e into conda:24.7.x Jul 24, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants