Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logger.warn w/ logger.warning #13963

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Jun 7, 2024

Description

This replaces calls to logger.warn with logger.warning. The former has been deprecated since Python 3.3 and generates DeprecationWarnings that can make output particularly in debugging and testing more noisy than necessary.

Sibling to conda/conda-build#5364.

Checklist - did you ...

As this is a purely internal change, I don't thing any of the following items apply.
However, it does remove the hack in gateways.logging to suppress the deprecation warnings.
Does that need special consideration?

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Other repos

@jezdez noted that the same issue is present in other repos in the ecosystem.
They may be addressed in a similar manner and in detail are the following:

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 7, 2024
@zklaus
Copy link
Contributor Author

zklaus commented Jun 7, 2024

pre-commit.ci autofix

Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #13963 will not alter performance

Comparing zklaus:warn-to-warning (2fa7ea2) with main (e8c2d9f)

Summary

✅ 21 untouched benchmarks

@zklaus zklaus marked this pull request as ready for review June 10, 2024 08:31
@zklaus zklaus requested a review from a team as a code owner June 10, 2024 08:31
kenodegard
kenodegard previously approved these changes Jun 11, 2024
beeankha
beeankha previously approved these changes Jun 11, 2024
@jezdez
Copy link
Member

jezdez commented Jun 11, 2024

@zklaus Could you please add a news file?

@zklaus zklaus dismissed stale reviews from beeankha and kenodegard via 2fa7ea2 June 12, 2024 08:38
@jezdez jezdez merged commit a89a894 into conda:main Jun 12, 2024
66 checks passed
beeankha pushed a commit to beeankha/conda that referenced this pull request Jun 12, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kenodegard kenodegard mentioned this pull request Jul 17, 2024
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants