-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace logger.warn w/ logger.warning #13963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Jun 7, 2024
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #13963 will not alter performanceComparing Summary
|
jezdez
reviewed
Jun 10, 2024
This was referenced Jun 11, 2024
kenodegard
previously approved these changes
Jun 11, 2024
beeankha
previously approved these changes
Jun 11, 2024
@zklaus Could you please add a news file? |
jezdez
approved these changes
Jun 12, 2024
beeankha
pushed a commit
to beeankha/conda
that referenced
this pull request
Jun 12, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces calls to
logger.warn
withlogger.warning
. The former has been deprecated since Python 3.3 and generatesDeprecationWarning
s that can make output particularly in debugging and testing more noisy than necessary.Sibling to conda/conda-build#5364.
Checklist - did you ...
As this is a purely internal change, I don't thing any of the following items apply.
However, it does remove the hack in gateways.logging to suppress the deprecation warnings.
Does that need special consideration?
news
directory (using the template) for the next release's release notes?Other repos
@jezdez noted that the same issue is present in other repos in the ecosystem.
They may be addressed in a similar manner and in detail are the following: