Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter tokens from more logging calls #13939

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented May 24, 2024

Description

Tokens could leak in verbose logs as part of the networking messages (urllib3, among others). This adds the already existing TokenURLFilters to more handlers to prevent it.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 24, 2024
@jaimergp jaimergp changed the title add TokenURLFilter to more handlers add TokenURLFilter to more logging handlers May 24, 2024
Copy link

codspeed-hq bot commented May 24, 2024

CodSpeed Performance Report

Merging #13939 will not alter performance

Comparing jaimergp:filter-tokens-logging (0883955) with main (ba8e16c)

Summary

✅ 21 untouched benchmarks

@jaimergp jaimergp marked this pull request as ready for review May 24, 2024 13:07
@jaimergp jaimergp requested a review from a team as a code owner May 24, 2024 13:07
conda/common/io.py Outdated Show resolved Hide resolved
conda/auxlib/logz.py Outdated Show resolved Hide resolved
conda/common/io.py Outdated Show resolved Hide resolved
@jezdez jezdez changed the title add TokenURLFilter to more logging handlers Filter tokens from more logging calls Jun 6, 2024
@jezdez jezdez merged commit e8c2d9f into conda:main Jun 7, 2024
68 checks passed
@jezdez jezdez mentioned this pull request Jun 12, 2024
3 tasks
@kenodegard kenodegard mentioned this pull request Jul 17, 2024
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants