Filter tokens from more logging calls #13939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
changed the title
CodSpeed Performance ReportMerging #13939 will not alter performanceComparing Summary
|
jezdez
requested changes
May 27, 2024
jezdez
reviewed
Jun 6, 2024
jezdez
approved these changes
Jun 6, 2024
jezdez
changed the title
jezdez
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tokens could leak in verbose logs as part of the networking messages (urllib3, among others). This adds the already existing
TokenURLFiltersto more handlers to prevent it.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?