Move conda env export to conda export
#13577
Conversation
beeankha
added
the
type::task
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #13577 will create unknown performance changesComparing Summary
|
beeankha
force-pushed
the
collapse-export-command
branch
from
d21d16a
to
ac16b24
Compare
beeankha
changed the title
conda env export to conda export commandconda env export to conda export command
tests/cli/test_main_export.py
Outdated
There was a problem hiding this comment.
is this a duplicate of the conda env export tests? can we combine them and parameterize the tests instead?
There was a problem hiding this comment.
It's been a little while since I touched this PR, but I'm pretty sure that the tests in tests/cli/test_main_export.py are not duplicates of the conda env export-related tests in tests/cli/test_env.py; eventually once conda env export is deprecated we can most likely move and update some of those related test_env.py tests into test_main_export.py.
There was a problem hiding this comment.
After thinking about it a bit more, I think it would be best to move the conda env export-related tests from tests/cli/test_env.py into test_main_export.py; at the same time we could move some of the functions used in multiple tests (e.g. env_is_created) into a test fixtures file so that they can be used in multiple places. In order to keep things as simple as possible, I'll do this work in a separate PR.
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
beeankha
changed the title
conda env export to conda export commandconda env export to conda export command
beeankha
force-pushed
the
collapse-export-command
branch
from
c513fd4
to
949810b
Compare
| @@ -43,7 +43,7 @@ def configure_parser(sub_parsers: _SubParsersAction | None, **kwargs) -> Argumen | |||
| ) | |||
| main_env_config.configure_parser(env_parsers) | |||
| main_env_create.configure_parser(env_parsers) | |||
| main_env_export.configure_parser(env_parsers) | |||
| main_export.configure_parser(env_parsers) | |||
There was a problem hiding this comment.
Ahh! Yes! This is exactly what we want!
conda/cli/main_export.py
Outdated
| filename = args.file | ||
| # check for the proper file extension; otherwise when the export file is used later, | ||
| # the user will get a file parsing error | ||
| if not filename.endswith((".yml", ".yaml")): |
There was a problem hiding this comment.
Can we use one of the yaml constants we already have defined? E.g.
conda/conda/common/configuration.py
Line 1310 in 6488061
There was a problem hiding this comment.
I wasn't aware of this constant, thanks for pointing it out!
beeankha
force-pushed
the
collapse-export-command
branch
from
4584d0c
to
365e496
Compare
beeankha
force-pushed
the
collapse-export-command
branch
from
39a8839
to
4f279cf
Compare
kenodegard
changed the title
conda env export to conda export commandconda env export to conda export
Description
Related epic:
conda_envintoconda#11633Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?