Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context bug with CONDA_REPODATA_FNS and improve some tests in test_solve #13490

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Fix context bug with CONDA_REPODATA_FNS and improve some tests in test_solve #13490

merged 6 commits into from
Jan 12, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 10, 2024 •
edited
Loading

Description

Some tests in test_solve were using the cached solver backend, so the solver parametrization was not working properly.

Additionally, we explicitly set CONDA_REPODATA_FNS so libmamba can recognize it was asked for (and not injected in conda.cli.install).

While doing this I discovered that the current conda will crash if CONDA_REPODATA_FNS is set to something not including repodata.json because a list is expected but context returns a tuple.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 10, 2024
@jaimergp jaimergp mentioned this pull request Jan 10, 2024
Closed
3 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #13490 will create unknown performance changes

Comparing jaimergp:test-solve-fixes (543ec7d) with main (7ed9d45)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@jaimergp jaimergp marked this pull request as ready for review January 10, 2024 21:29
@jaimergp jaimergp requested a review from a team as a code owner January 10, 2024 21:29
@jaimergp
Copy link
Contributor Author 

4084.33s call     tests/test_create.py::test_install_features[classic]

o.o WHAT

@jezdez
Copy link
Member

jezdez commented Jan 11, 2024

@jaimergp Any idea where the 3.12 test failures comes from?

@jaimergp
Copy link
Contributor Author

I'm looking into it. I can reproduce locally and only with 3.12. Very intriguing. Also the test is slow. 4000s in CI, 1000s locally o.o

@jaimergp
Copy link
Contributor Author

I think it's an interaction between main and conda-forge that makes the classic solver faint :P These integration tests shouldn't assume compatibility with the pre-configured channels when issuing a --channel=xxx argument, so I added an --override-channels flag and now it passes (and super fast!).

@jaimergp
Copy link
Contributor Author

Passing now @jezdez

@jezdez jezdez merged commit ae29531 into conda:main Jan 12, 2024
75 checks passed
@jaimergp jaimergp mentioned this pull request Jan 12, 2024
Open
@kenodegard kenodegard mentioned this pull request Jan 15, 2024
Closed
1 task
@kenodegard kenodegard mentioned this pull request Jan 30, 2024
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaimergp @jezdez @conda-bot