Save/restore ConanOutput global state when using Conan API's command #17095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
changed the title
AbrilRBS
commented
Oct 6, 2024
| # get redefined when running a command and leak to the calling scope | ||
| # if running from a custom command. | ||
| # Store the old one and restore it after the command execution as a workaround. | ||
| _conan_output_level = ConanOutput._conan_output_level |
There was a problem hiding this comment.
This pattern is spread thru the code in a few places, we could have something like this maybe?
@contenxtmanager
def restore_after(entity, *attributes):
old_values = [getvalue(entity, attribute) for attribute in attributes)
try:
yield
finally:
for attribute, old_value in zip(attributes, old_values):
setattr(entity, attribute, old_value)
which would be used in 3-4 places from a quick look. Thoughts?
There was a problem hiding this comment.
I have reviewed all finally in our code, I am not sure it is worth the abstraction at this point, but we can discussed, I am not opposed.
memsharded
approved these changes
Oct 6, 2024
| # get redefined when running a command and leak to the calling scope | ||
| # if running from a custom command. | ||
| # Store the old one and restore it after the command execution as a workaround. | ||
| _conan_output_level = ConanOutput._conan_output_level |
There was a problem hiding this comment.
I have reviewed all finally in our code, I am not sure it is worth the abstraction at this point, but we can discussed, I am not opposed.
franramirez688
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Restore ConanOutput global state when using
CommandsAPI.Docs: Omit