-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.1 compatibility - Passing null to parameter #1 ($string) of type string is deprecated - VersionParser.php:105 #134
Comments
Do you have a full stack trace for this? If you run composer with |
Should be fixed but I'm still interested to see a stack trace if you have one. |
Well, now I can't reproduce it. I apologize, I might have been using a snapshot due to (composer/composer#10631), and this morning I updated composer to 2.3.2. |
I see, no worries. |
Isn't the real fix here to fix the caller that is making the invalid call. Not valid to call a function typed as string, with null? |
Caller has been fixed in composer already, but IMO this is still good to do to mimick a type hint, which would type juggle null into string as well. I don't want to drop 5.3 support just yet in this lib to avoid having to maintain too many branches. |
I am using version 2.2.6 with PHP8.1.13
|
The latest 2.2.x release of Composer is 2.2.18, not 2.2.6. Please try to use the latest version. |
C:\jenkins-php-tools>composer update
Loading composer repositories with package information
Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated in phar://C:/ProgramData/ComposerSetup/bin/composer.phar/vendor/composer/semver/src/VersionParser.php:105
The text was updated successfully, but these errors were encountered: