Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix wscat invocation and add TLS note #663

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

arirubinstein
Copy link
Contributor

Updates the docs to fix the subscription wscat command


PR checklist

  • [na] Tests written/updated
  • [na] Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@arirubinstein arirubinstein requested a review from a team as a code owner April 6, 2023 22:13
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arirubinstein!

@thanethomson thanethomson added documentation Improvements or additions to documentation backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x labels Apr 7, 2023
@thanethomson thanethomson merged commit ba0d03b into cometbft:main Apr 7, 2023
mergify bot pushed a commit that referenced this pull request Apr 7, 2023
Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ba0d03b)
mergify bot pushed a commit that referenced this pull request Apr 7, 2023
Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ba0d03b)
mergify bot pushed a commit that referenced this pull request Apr 7, 2023
Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ba0d03b)
thanethomson pushed a commit that referenced this pull request Apr 7, 2023
Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ba0d03b)

Co-authored-by: Ari Rubinstein <arirubinstein@users.noreply.github.com>
thanethomson pushed a commit that referenced this pull request Apr 7, 2023
Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ba0d03b)

Co-authored-by: Ari Rubinstein <arirubinstein@users.noreply.github.com>
thanethomson pushed a commit that referenced this pull request Apr 7, 2023
Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ba0d03b)

Co-authored-by: Ari Rubinstein <arirubinstein@users.noreply.github.com>
thanethomson added a commit that referenced this pull request May 6, 2023
Co-authored-by: Thane Thomson <connect@thanethomson.com>
roy-dydx pushed a commit to dydxprotocol/cometbft that referenced this pull request Jul 11, 2023
)

Co-authored-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ba0d03b)

Co-authored-by: Ari Rubinstein <arirubinstein@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants