test(e2e): fix debug level on workflow #3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cason
approved these changes
Aug 28, 2024
.changelog/unreleased/improvements/3880-e2e-manual-debug-workflow.md
Outdated
Show resolved
Hide resolved
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
The `log_level` on the `e2e-manual-debug` was set incorrectly. This PR fixes it. Realized after running a `e2e-manual-debug` workflow,[ all tests failed](https://github.com/cometbft/cometbft/actions/runs/10597473846) with: ``` validator01 | E[2024-08-28|13:20:29.330] failed to setup config: expected list in a form of "module:level" pairs, given pair debug, list [debug p2p:info] ``` instead of using log level: ``` "debug,p2p:info" ``` this PR fixes it and uses the correct one: ``` "*:debug,p2p:info" ``` > NOTE: Also added a changelog entry for the new e2e workflow, previous PR only had a changelog entry for the generator new log level option #### PR checklist - [ ] Tests written/updated - [X] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit 5ab57c5)
3 tasks
andynog
added a commit
that referenced
this pull request
Aug 28, 2024
The `log_level` on the `e2e-manual-debug` was set incorrectly. This PR fixes it. Realized after running a `e2e-manual-debug` workflow,[ all tests failed](https://github.com/cometbft/cometbft/actions/runs/10597473846) with: ``` validator01 | E[2024-08-28|13:20:29.330] failed to setup config: expected list in a form of "module:level" pairs, given pair debug, list [debug p2p:info] ``` instead of using log level: ``` "debug,p2p:info" ``` this PR fixes it and uses the correct one: ``` "*:debug,p2p:info" ``` > NOTE: Also added a changelog entry for the new e2e workflow, previous PR only had a changelog entry for the generator new log level option #### PR checklist - [ ] Tests written/updated - [X] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #3888 done by [Mergify](https://mergify.com). Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
log_levelon thee2e-manual-debugwas set incorrectly. This PR fixes it.Realized after running a
e2e-manual-debugworkflow, all tests failed with:instead of using log level:
this PR fixes it and uses the correct one:
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments