Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Add log level option in e2e generator and manual debug workflow #3881

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

andynog
Copy link
Contributor

@andynog andynog commented Aug 27, 2024

close: #3880

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@andynog andynog self-assigned this Aug 27, 2024
@andynog andynog requested review from a team as code owners August 27, 2024 20:54
@andynog andynog added enhancement New feature or request e2e Related to our end-to-end tests labels Aug 27, 2024
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

But should we document better on the PR title or elsewhere that we are also adding a new GH workflow?

@andynog andynog changed the title test(e2e): Add log level option in e2e generator test(e2e): Add log level option in e2e generator and manual debug workflow Aug 28, 2024
@andynog andynog added the backport-to-v1.x Tell Mergify to backport the PR to v1.x label Aug 28, 2024
@andynog
Copy link
Contributor Author

andynog commented Aug 28, 2024

I will also backport this to v1.x to help troubleshooting the nightly issues there

@andynog andynog added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 24119d2 Aug 28, 2024
39 checks passed
@andynog andynog deleted the andy/e2e-generator-debug branch August 28, 2024 12:40
mergify bot pushed a commit that referenced this pull request Aug 28, 2024
…kflow (#3881)

close: #3880

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [X] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 24119d2)
andynog added a commit that referenced this pull request Aug 28, 2024
…kflow (backport #3881) (#3887)

close: #3880 

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [X] Updated relevant documentation (`docs/` or `spec/`) and code
comments
<hr>This is an automatic backport of pull request #3881 done by
[Mergify](https://mergify.com).

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v1.x Tell Mergify to backport the PR to v1.x e2e Related to our end-to-end tests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(e2e): Add log level option in e2e generator and manual debug workflow
3 participants