feat(crypto)!: remove sr25519 curve #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like no one is actually using it
melekes
added
backport-to-v1.x
cason
approved these changes
Aug 8, 2024
Why? To give a chance to migrate? If they are using it w/ 0.38 line, then they would be able to continue using it for at least 1 year. Not sure we want to support sr25519 (in v1) for 2 years. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
looks like no one is actually using it --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit ab5b20a) # Conflicts: # crypto/sr25519/privkey.go # test/e2e/generator/generate.go # test/e2e/pkg/testnet.go
4 tasks
Ok, you got a point. But if some asks for it, we need to re-introduce. |
melekes
added a commit
that referenced
this pull request
Aug 9, 2024
looks like no one is actually using it --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3646 done by [Mergify](https://mergify.com). --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like no one is actually using it
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments