Skip to content

Semantic version still references TM #1200

Closed
@lasarojc

Description

TMCoreSemVer should be renamed to CMTSemVer.
And the version output by the binary should be named CometBFT, not Tendermint.

From the codebase,

  grep -ri version.TMCoreSemVer .
  ./statesync/syncer_test.go:			Software: version.TMCoreSemVer,
  ./statesync/stateprovider.go:		Software:  version.TMCoreSemVer,
  ./cmd/cometbft/commands/version.go:		cmtVersion := version.TMCoreSemVer
  ./proxy/version.go:	Version:      version.TMCoreSemVer,
  ./test/e2e/README.md:# In the example below, if the local version.TMCoreSemVer value is "v0.34.24",
  ./test/e2e/generator/generate.go:	return findLatestReleaseTag(version.TMCoreSemVer, tags)
  ./config/config.go:		Version:            version.TMCoreSemVer,
  ./state/rollback.go:			Software: version.TMCoreSemVer,
  ./state/rollback_test.go:			Software:  version.TMCoreSemVer,
  ./state/rollback_test.go:			Software:  version.TMCoreSemVer,
  ./state/rollback_test.go:			Software: version.TMCoreSemVer,
  ./state/state.go:	Software: version.TMCoreSemVer,
  ./.goreleaser.yml:      - -s -w -X github.com/cometbft/cometbft/version.TMCoreSemVer={{ .Version }}
  ./node/setup.go:		"tendermint_version", version.TMCoreSemVer,
  ./node/node.go:		Version:       version.TMCoreSemVer,## Bug Report

When running

  2023-08-02 15:12:35 I[2023-08-02|18:12:35.314] Version info                                 module=main tendermint_version=0.39.0-dev abci=2.0.0 block=11 p2p=8 commit_hash=

Metadata

Assignees

No one assigned

    Labels

    backport-to-v0.37.xTell Mergify to backport the PR to v0.37.xbackport-to-v0.38.xTell Mergify to backport the PR to v0.38.xbugSomething isn't working

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions