Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Ensure that thecolour.utilities.as_float definition do not reduce dimensionality #1189

Merged
merged 1 commit into from
Jul 29, 2023
Merged

PR: Ensure that thecolour.utilities.as_float definition do not reduce dimensionality #1189

merged 1 commit into from
Jul 29, 2023

Conversation

KelSolaar
Copy link
Member

Summary

This PR ensures that the colour.utilities.as_float definition do not reduce dimensionality. We piggy backed on some of its behaviour but it is inconsistent and caused issues when processing 1-pixel images.

References #1188.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • [N/A] The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.3 milestone Jul 29, 2023
@KelSolaar KelSolaar force-pushed the feature/dimensionality_reduction branch from c93a756 to 24e0321 Compare July 29, 2023 03:53
@coveralls
Copy link

coveralls commented Jul 29, 2023 •
edited
Loading

Coverage Status

coverage: 99.775%. remained the same when pulling 58628e4 on feature/dimensionality_reduction into 708ded0 on develop.

@KelSolaar KelSolaar force-pushed the feature/dimensionality_reduction branch from 24e0321 to 58628e4 Compare July 29, 2023 05:26
@KelSolaar KelSolaar merged commit 1199e81 into develop Jul 29, 2023
@KelSolaar KelSolaar deleted the feature/dimensionality_reduction branch July 29, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@KelSolaar @coveralls