Skip to content

Pylint complains that subclasses of ColumnBase leave __iter__() unimplemented #2612

Closed
@jborman-exos

Description

@jborman-exos

Related to the fix released for #2606, running pylint over a local subclass of ColumnBase raises the following:

Method '__iter__' is abstract in class 'ColumnBase' but is not overridden (abstract-method)

Raising NotimplementedError implies that a concrete class is meant to implement this abstract method. According to the python docs, if __iter__ is never to be implemented on a subclass of ColumnBase, then it should be set to None

Activity

added a commit that references this issue on Aug 26, 2022
coleifer

coleifer commented on Aug 26, 2022

@coleifer
Owner

No problem, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Pylint complains that subclasses of `ColumnBase` leave `__iter__()` unimplemented · Issue #2612 · coleifer/peewee