Skip to content
This repository has been archived by the owner on Mar 1, 2021. It is now read-only.

Clean up #242

Merged
merged 25 commits into from
Mar 23, 2020
Merged

Clean up #242

merged 25 commits into from
Mar 23, 2020

Conversation

Urhengulas
Copy link
Collaborator

Description

This PR cleans the repo up in various ways:

  • rethink folderstructure --> less folders in top-level directory

Fixes #22 #73

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Cleanup (changes in structure but not functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make run-instagram
  • make run-twitter
  • circle-ci passes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Urhengulas Urhengulas requested review from 1Jo1 and jo-fr March 22, 2020 16:24
Copy link
Member

@jo-fr jo-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved the pending issues by myself. Other than that LGTM 👍

@Urhengulas Urhengulas merged commit ea75111 into master Mar 23, 2020
@Urhengulas Urhengulas deleted the clean-up branch March 23, 2020 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify naming conventions in project
2 participants