-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mpi (device-aware) examples backend agnostic #11
Merged
DuncanMcBain
merged 11 commits into
codeplaysoftware:main
from
JackAKirk:MPI-backend-agnostic
Apr 4, 2024
Merged
Make mpi (device-aware) examples backend agnostic #11
DuncanMcBain
merged 11 commits into
codeplaysoftware:main
from
JackAKirk:MPI-backend-agnostic
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
rafbiels
requested changes
Mar 25, 2024
Make buffer example work with all plugin and runtime backend combinations
Some general formatting/style changes. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
rafbiels
reviewed
Mar 27, 2024
JackAKirk
commented
Mar 27, 2024
JackAKirk
commented
Mar 27, 2024
rafbiels
reviewed
Apr 4, 2024
rafbiels
approved these changes
Apr 4, 2024
JackAKirk
changed the title
Make mpi device (GPU-aware) examples backend agnostic
Make mpi (device-aware) examples backend agnostic
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL + MPI should work in this way for any backend that supports MPI aware "device" memory.
We know that these samples work on cuda/hip backends, they are supposed to work on L0, and indeed in theory should also work when the device memory corresponds to cpu memory (e.g. opencl cpu/native cpu backends).