Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use first image from article top_node #35

Merged
merged 6 commits into from
Feb 7, 2014
Merged

Use first image from article top_node #35

merged 6 commits into from
Feb 7, 2014

Conversation

otemnov
Copy link
Contributor

@otemnov otemnov commented Feb 3, 2014

Use first image from clean top_node and only then try set_reddit_top_img
Also set_top_image checks for image requirements before set (i.e. checks size, dimension ratio and etc)

@codelucas
Copy link
Owner

I'll read over this and merge in a few days, thanks a ton!

@otemnov
Copy link
Contributor Author

otemnov commented Feb 5, 2014

otemnov@d77c3a3 should go as separate PR

@codelucas
Copy link
Owner

Sorry for the late response, school was picking up.

GREAT refactoring and additions man! Merged.

codelucas added a commit that referenced this pull request Feb 7, 2014
@codelucas
Merge pull request #35 from otemnov/original
f5b5ceb 
Use first image from article top_node
@codelucas codelucas merged commit f5b5ceb into codelucas:master Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otemnov @codelucas