Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: versionInfo #1407

Merged

Conversation

marcobiedermann
Copy link
Contributor

Add full test coverage resolving the versionInfo

--------------|---------|----------|---------|---------|---------------------------------------
File          | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------|---------|----------|---------|---------|---------------------------------------
 version.ts   |     100 |      100 |     100 |     100 |
--------------|---------|----------|---------|---------|---------------------------------------

.intercept({
path: `/${platform}/${version}`,
})
.reply(404, 'MESSAGE');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any arbitrary message would work as the service returns XML, which can not be parsed by the .json() method

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (9e14515) to head (9693ac3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
+ Coverage   91.37%   93.20%   +1.83%     
==========================================
  Files           4        5       +1     
  Lines         313      324      +11     
  Branches       86       85       -1     
==========================================
+ Hits          286      302      +16     
+ Misses         25       20       -5     
  Partials        2        2              
Flag Coverage Δ
demo 93.20% <ø> (+1.83%) ⬆️
macos-latest 93.20% <ø> (+1.83%) ⬆️
script 93.20% <ø> (+1.83%) ⬆️
ubuntu-latest 93.20% <ø> (+1.83%) ⬆️
version 93.20% <ø> (+1.83%) ⬆️
windows-latest 93.20% <ø> (+1.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcobiedermann
Copy link
Contributor Author

Some workflows are failing as they were not up to date on main for quite some time, as mentioned in #1396 (comment).
I suggest disabling them as a required check and open up a follow-up ticket to fix them first, before applying those rules to all branches

marcobiedermann and others added 2 commits July 16, 2024 16:39
Add full test coverage resolving the `versionInfo`
@thomasrockhu-codecov thomasrockhu-codecov merged commit a06c39c into codecov:main Jul 16, 2024
10 checks passed
@marcobiedermann marcobiedermann deleted the feature/version-tests branch July 17, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants