Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bullet body memory leaks #17306

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

yeling584283398
Copy link
Contributor

@yeling584283398 yeling584283398 commented Jul 4, 2024

Re: #

Changelog

*When creating the body, the id is used as the key to put it in BulletCache, but when destroying it, the body is used as the key, which makes it impossible to destroy


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Jul 4, 2024

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar requested a review from minggo July 4, 2024 15:12
@yeling584283398
Copy link
Contributor Author

Do I need to fix eslint issues that were not caused by my changes?

@minggo
Copy link
Contributor

minggo commented Jul 5, 2024

You are appreciated if you do it. But it is not necessary to do it.

@minggo minggo merged commit a4221fb into cocos:v3.8.5 Jul 5, 2024
10 of 11 checks passed
@minggo
Copy link
Contributor

minggo commented Jul 5, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants