Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Cocogitto mono #392

Closed
wants to merge 40 commits into from
Closed

(WIP) Cocogitto mono #392

wants to merge 40 commits into from

Conversation

oknozor
Copy link
Collaborator

@oknozor oknozor commented May 15, 2024

No description provided.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 89.75762% with 524 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (ded0d4d) to head (471605f).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/commands/cog-edit/src/lib.rs 0.00% 96 Missing ⚠️
crates/commands/cog-log/src/lib.rs 53.70% 50 Missing ⚠️
crates/commands/cog-commit/src/lib.rs 66.89% 48 Missing ⚠️
crates/libs/cocogitto-config/src/git_hook.rs 18.18% 45 Missing ⚠️
crates/commands/cog-bump/src/lib.rs 95.67% 43 Missing ⚠️
crates/cog/src/main.rs 69.38% 30 Missing ⚠️
crates/commands/cog-bump/src/monorepo.rs 93.90% 30 Missing ⚠️
crates/libs/cocogitto-commit/src/lib.rs 77.60% 28 Missing ⚠️
crates/libs/cocogitto-tag/src/error.rs 18.75% 26 Missing ⚠️
crates/libs/cocogitto-bump/src/error.rs 0.00% 25 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   86.66%   88.86%   +2.20%     
==========================================
  Files          49       59      +10     
  Lines        6987     9118    +2131     
==========================================
+ Hits         6055     8103    +2048     
- Misses        932     1015      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oknozor
Copy link
Collaborator Author

oknozor commented May 16, 2024

Current status
image

@oknozor
Copy link
Collaborator Author

oknozor commented May 18, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented May 18, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented May 19, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented May 19, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented May 19, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented May 19, 2024

Todos:

  1. Extract remaining commands in cocogitto into their dedicated crate.
  2. Remove use only cocogitto-config in the cli.
  3. Rename cog to cocogitto.
  4. cocogitto-hook doesn't need cocogitto-tag, just semver + a display impl for HookVersion.
  5. Remove usage of cocogitto-commit in cocogitto-changelog (flatten ChangelogCommit).
  6. Make use of this_error for non-user facing errors?
  7. Track usage of log (should be only used in command crates).
  8. rewrite the CI and Release steps to monorepo mode.
  9. Pre-release.
  10. Start dog fooding.

There will be a lot more to do, but from there we should be able to start reviewing per crate test coverage, split e2e tests into their respective command crates, implement the missing mutli tag ref for mono repo changelogs.

@oknozor
Copy link
Collaborator Author

oknozor commented May 21, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented May 21, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented Jun 18, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented Jun 19, 2024

image

@oknozor
Copy link
Collaborator Author

oknozor commented Jun 19, 2024

image

Copy link

cocogitto-bot bot commented Jun 20, 2024

✔️ 6a6bf74...471605f - Conventional commits check succeeded.

@oknozor
Copy link
Collaborator Author

oknozor commented Nov 28, 2024

Unfortunately thats a no go, we need a dependency tree solver in cocogitto to be able to release this on crates.io.
This might serve as an exemple for later monorepo refactoring.

@oknozor oknozor closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants