UI: bugfixes: footer alignment and bad server responses #5703
Conversation
|
I'm not sure we need to slip this in ASAP. Yes, the footer's position in master isn't ideal. However, this PR still has a bug in the footer positioning. Specifically, with a fresh new cluster, when the "opt in" banner is showing, the footer is hidden just below the bottom edge of the window:
The footer reappears when I close the banner:
@petermattis: any thoughts here? |
maxlang
force-pushed
the
maxlang/ui-footer-fix
branch
from
e23505d to
527c411
Compare
|
I'll take another look, but this is a big visual improvement. |
|
OK, let's get this in the next build, and also get a fix for the case where the banner is visible later. Comments from the review on Reviewable.io |
maxlang
force-pushed
the
maxlang/ui-footer-fix
branch
from
527c411 to
c3da613
Compare
maxlang
changed the title
|
Added a fix for bad responses from external requests. |
| @@ -128,6 +128,7 @@ module Models { | |||
| m.request<VersionList>({ | |||
| url: `${COCKROACHLABS_ADDR}/api/clusters/updates?uuid=${this.clusterID}&version=${nodeStatuses[0].build_info.tag}`, | |||
| config: Utils.Http.XHRConfig, | |||
| background: true, | |||
There was a problem hiding this comment.
Do you also need this on the other methods like unregister? It's still hanging on those.
|
ui/ts/util/http.ts, line 6 [r3] (raw file): Comments from the review on Reviewable.io |
|
ui/ts/util/http.ts, line 6 [r3] (raw file): Comments from the review on Reviewable.io |
|
This is expected - it's actually the error we're getting back from the Cockroach Labs server. We have an error parsing it because it's not JSON, but now we just log and continue, whereas before this error was bubbled up. |
maxlang
force-pushed
the
maxlang/ui-footer-fix
branch
from
02e341b to
bbf72a8
Compare
maxlang
force-pushed
the
maxlang/ui-footer-fix
branch
from
bbf72a8 to
d20fe13
Compare
|
tested on a hacked up version of reg server that sleeps for 10 seconds on all HTTP requests Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions. Comments from the review on Reviewable.io |
A bug caused the footer to be misaligned on certain pages.
Before:
After:
This change is