Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.

pkg/storage/store.go, line 963 at r1 (raw file):

// there may be active leases held by some of the Store's Replicas.
// When called with 'false', returns to the normal mode of operation.
func (s *Store) SetDraining(drain bool) error {

As we discussed at lunch, there are multiple kinds of draining (leases, replicas, clients, etc), Probably better to keep this DrainLeases unless we're going to adopt a new naming scheme in which "draining" unambiguously refers to leases. (it's also best to do renames like this in a separate commit from any functional change)

Comments from Reviewable

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.

pkg/storage/store.go, line 963 at r1 (raw file):

There are multiple kinds of draining, but in the context of a Store I'm not sure it makes sense to separate the draining of leases and replicas. This is because the more important distinction is draining for a restart or draining for a removal. You would want to stop accepting replicas in both cases to avoid a possible loss of quorum. I think I'll keep the rename (put it in its own commit) and later on add a boolean forRemoval that will transfer away replicas from a store.

Comments from Reviewable

Reviewed 2 of 7 files at r1, 5 of 5 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from Reviewable