New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comma added to line 54 of Writing_Linter_Bears.rst #6002

Closed

tab1tha wants to merge 1 commit into coala:master from tab1tha:addcomma

tab1tha commented Mar 21, 2019 •

edited

Loading

This PR closes #5943

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use corobo mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

gitmate-bot added process/pending review size/XS area/aspects area/documentation difficulty/newcomer labels

frextrite suggested changes

View reviewed changes

frextrite left a comment •

edited

Loading

Hi @tab1tha , the changes look good but please follow the Commit Guidelines and amend your commit message, indicating which file is being changed, and also add a commit body.

Gromy1211 commented Mar 22, 2019

Hi, I think you may refer to https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html and change your commit message ;)

Collaborator

gitmate-bot commented Mar 22, 2019

Comment on 6e2393c.

Shortlog of the HEAD commit contains 73 character(s). This is 23 character(s) longer than the limit (73 > 50).

Origin: GitCommitBear, Section: commit.

Collaborator

gitmate-bot commented Mar 22, 2019

Comment on 6e2393c.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

Collaborator

gitmate-bot commented Mar 22, 2019

Comment on 73d2136.

Shortlog of the HEAD commit contains 52 character(s). This is 2 character(s) longer than the limit (52 > 50).

Origin: GitCommitBear, Section: commit.

Collaborator

gitmate-bot commented Mar 22, 2019

Comment on 73d2136.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

Origin: GitCommitBear, Section: commit.

Member

abhishalya commented Mar 22, 2019

@tab1tha You have multiple commits, squash them into one. Also follow the commit guidelines properly. After creating a commit, just run coala --non-interactive and make sure that it doesn't throw any issues with your changes.

Collaborator

gitmate-bot commented Mar 22, 2019

Comment on 3543c7d.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

Collaborator

gitmate-bot commented Mar 22, 2019

Comment on 5f62e93.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

Author

tab1tha commented Mar 22, 2019

@abhishalya Please help.I do not know why it isstill failing.Should I remove the underscores from the file name?


          Writing_Linter_Bears.rst: Add comma

899adf9

Comma added at line 54,before pylint,for fluency

Closes #5943

chay2199 approved these changes

View reviewed changes

chay2199 suggested changes

View reviewed changes

chay2199 left a comment •

edited

Loading

Please change your commit message, comma added -> add comma

KVGarg reviewed

View reviewed changes

Contributor

KVGarg left a comment

Please don't open PRs unless you are assigned on an issue. Please ask on issue or gitter to get yourself assigned on it!
Since you have opened PR now, don't close it! But take care from next time 😇

Member

jayvdb commented Jun 27, 2019

Please rebase your commit on top of master and re-push.

BharathKumarRavichandran commented Dec 9, 2020

I think the PR can be closed since the head fork repository has been deleted.

Member

abhishalya commented May 14, 2021

Closing as the PR was abandoned.

abhishalya closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/aspects area/documentation difficulty/newcomer process/pending review size/XS