Air gap support #491
Merged
Air gap support #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangedeng
force-pushed
the
air-gap-support
branch
4 times, most recently
from
e7f0949 to
4ac605d
Compare
Jason-ZW
requested changes
Aug 15, 2022
pkg/types/autok3s.go
Outdated
Comment on lines
52
to
53
| PackagePath string `json:"packagePath,omitempty" yaml:"packagePath,omitempty"` | ||
| PackageName string `json:"packageName,omitempty" yaml:"packageName,omitempty"` |
There was a problem hiding this comment.
Better to use the same format
PackagePath json:"package-path,omitempty" yaml:"package-path,omitempty"
PackageName json:"package-name,omitempty" yaml:"package-name,omitempty"
cmd/airgap/remove.go
Outdated
Comment on lines
36
to
42
| if err := common.DefaultDB.DeletePackage(name); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := pkgairgap.RemovePackage(name); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Is it better to delete it physically first and then delete it from the DB?
pkg/common/package.go
Outdated
|
|
||
| type Package struct { | ||
| Name string `json:"name,omitempty" gorm:"primaryKey;->;<-:create"` | ||
| K3sVersion string `json:"k3sVeersion,omitempty"` |
pkg/airgap/file_scp.go
Outdated
| defer scpClient.RemoveDirectory(tmpDir) | ||
|
|
||
| for local, remote := range files { | ||
|
|
orangedeng
force-pushed
the
air-gap-support
branch
from
4ac605d to
f0b1bdf
Compare
As design, following actions are supported: - create - update - remove - ls - import - export - update-install-script The downloaded resource will be stored in package dir under CfgPath. The design can be found in cnrancher#480.
When creating or upgrading cluster, you can specify the packageName or packagePath to use airgap install.
orangedeng
force-pushed
the
air-gap-support
branch
from
f0b1bdf to
33b347c
Compare
|
Updated |
Jason-ZW
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to issue: #448