Allow cpu_utilization larger than 1.0. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@htuch PTAL. |
markdroth
changed the title
|
I think this is the right thing to do, since there are a lot of cluster systems out there that have varying levels of oversubscription and opportunistic provisioning, so I think it will not be uncommon to need values greater than 1.0 here. |
htuch
reviewed
Apr 27, 2023
| // should be derived from the latest sample or measurement. | ||
| double cpu_utilization = 1 [(validate.rules).double.gte = 0, (validate.rules).double.lte = 1]; | ||
| // should be derived from the latest sample or measurement. The value may be | ||
| // larger than 1.0 when the usage exceeds the soft limit. |
There was a problem hiding this comment.
"exceeds a reporter dependent notion of soft limits". I think it's legit, just want to be clear who is specifying the soft limit.
|
Needs DCO fix (or possibly new PR). |
Signed-off-by: Yousuk Seung <ysseung@google.com>
yousukseung
force-pushed
the
utilization_over_1
branch
from
00775ef to
8744878
Compare
|
I rebased to fix the DCO error per the link above. |
htuch
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yousuk Seung ysseung@google.com