Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lost dict def for EcalRecHitSoA #47048

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

smuzaffar
Copy link
Contributor

This fixes the wrong dict definition issue see #46453 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = DataFormats/EcalRecHit, CUDADataFormats/EcalRecHitSoA

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Utilities/ReleaseScripts (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7fb91/43651/summary.html
COMMIT: 52559af
CMSSW: CMSSW_15_0_X_2025-01-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47048/43651/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818730
  • DQMHistoTests: Total failures: 467
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818243
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Jan 7, 2025

Comparison differences are related to #39803 and #46416

@makortel
Copy link
Contributor

makortel commented Jan 7, 2025

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 25a6c27 into cms-sw:master Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants