-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make units dd4hep-dependent in Run3 Tracker algo #32863
Conversation
…ration to dd4hep unit change.
…fter DetId building.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32863/21091
|
A new Pull Request was created by @ghugo83 for master. It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
1 similar comment
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c5206/12828/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Make units dd4hep-dependent.
This is in preparation of DD4hep unit change.
@cvuosalo @civanch @ianna
Tested against all regressions: compared all coordinates.