Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR profiling: remove running of IgProf for memory and cpu profiling and remove running of JeProf for memory profiling. #2415

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 17, 2025

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung for branch master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2025

cms-bot internal usage

@gartung
Copy link
Member Author

gartung commented Jan 17, 2025

enable profiling

@gartung
Copy link
Member Author

gartung commented Jan 17, 2025

please test

@cmsbuild
Copy link
Contributor

Pull request #2415 was updated.

@gartung
Copy link
Member Author

gartung commented Jan 17, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38f7e2/43834/summary.html
COMMIT: 3434e20
CMSSW: CMSSW_15_0_X_2025-01-17-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2415/43834/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3819017
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #2415 was updated.

@gartung
Copy link
Member Author

gartung commented Jan 18, 2025

please test

@gartung
Copy link
Member Author

gartung commented Jan 18, 2025

abort

@cmsbuild
Copy link
Contributor

Pull request #2415 was updated.

@gartung
Copy link
Member Author

gartung commented Jan 18, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38f7e2/43840/summary.html
COMMIT: 2e1d1d3
CMSSW: CMSSW_15_0_X_2025-01-17-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2415/43840/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3819017
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@gartung , is the ready to go in ?

@gartung
Copy link
Member Author

gartung commented Jan 20, 2025

yes

@smuzaffar smuzaffar merged commit 3f5f038 into cms-sw:master Jan 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants