Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metainfo): fix the probleam that transient keys of metainfo are transmitted continuously #842

Merged

Conversation

YangruiEmma
Copy link
Member

@YangruiEmma YangruiEmma commented Mar 1, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

fix: 修复 metainfo 的 transient keys 被持续透传问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Which version introduced the bug: no, pre-release
zh(optional): 哪个版本引入的问题:无,pre-release

Which issue(s) this PR fixes:

#837

@YangruiEmma YangruiEmma requested review from a team as code owners March 1, 2023 15:09
@YangruiEmma YangruiEmma force-pushed the fix/metainfo_transient_key branch from 65a2828 to 891c762 Compare March 1, 2023 17:57
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08 ⚠️

Comparison is base (0283371) 69.77% compared to head (9da83b0) 69.70%.

❗ Current head 9da83b0 differs from pull request most recent head c91aabd. Consider uploading reports for the commit c91aabd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #842      +/-   ##
===========================================
- Coverage    69.77%   69.70%   -0.08%     
===========================================
  Files          236      236              
  Lines        17445    17445              
===========================================
- Hits         12173    12160      -13     
- Misses        4159     4171      +12     
- Partials      1113     1114       +1     
Impacted Files Coverage Δ
pkg/transmeta/metainfo.go 90.47% <ø> (-0.23%) ⬇️
pkg/remote/bound/transmeta_bound.go 87.50% <100.00%> (+0.40%) ⬆️
pkg/remote/trans/netpollmux/mux_conn.go 64.38% <0.00%> (-4.11%) ⬇️
pkg/remote/codec/default_codec.go 71.71% <0.00%> (-2.64%) ⬇️
pkg/remote/trans/nphttp2/grpc/controlbuf.go 81.23% <0.00%> (-1.33%) ⬇️
pkg/remote/trans/netpollmux/server_handler.go 68.87% <0.00%> (-0.78%) ⬇️
pkg/remote/trans/nphttp2/grpc/http2_client.go 72.11% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YangruiEmma YangruiEmma merged commit 14952ec into cloudwego:develop Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants