Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix some code smells found by golangci-lint #18

Merged
merged 1 commit into from
Jul 16, 2021
Merged

*: fix some code smells found by golangci-lint #18

merged 1 commit into from
Jul 16, 2021

Conversation

rleungx
Copy link
Contributor

@rleungx rleungx commented Jul 16, 2021

Just as the title says.

@rleungx
fix some code smells found by golangci-lint
32a27ac 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@lsjbd
Copy link
Contributor

lsjbd commented Jul 16, 2021

Would you mind telling us what check rules you used that discovered those issues? We might added it to the CI workflow.

Thank your very much.

@YangruiEmma YangruiEmma merged commit 65b943a into cloudwego:develop Jul 16, 2021
@rleungx
Copy link
Contributor Author

rleungx commented Jul 20, 2021

Would you mind telling us what check rules you used that discovered those issues? We might added it to the CI workflow.

Thank your very much.

Using the default rule is enough. ^ ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsjbd lsjbd lsjbd approved these changes

@YangruiEmma YangruiEmma YangruiEmma approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @lsjbd @YangruiEmma