Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: better coding style with gofumpt -extra #124

Merged
merged 1 commit into from
Sep 22, 2021
Merged

style: better coding style with gofumpt -extra #124

merged 1 commit into from
Sep 22, 2021

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Sep 14, 2021

Format code with a stricter format tool.

@YangruiEmma
Copy link
Member

Thanks @kevwan. Could you also add gofumpt check in push-check.yml?

@kevwan
Copy link
Contributor Author

kevwan commented Sep 15, 2021 •
edited
Loading

Thanks @kevwan. Could you also add gofumpt check in push-check.yml?

gofumpt is from: https://github.com/mvdan/gofumpt

I'm not sure how to use this kind of tool in push-check.yml

@YangruiEmma
Copy link
Member

YangruiEmma commented Sep 20, 2021 •
edited
Loading

Thanks @kevwan. Could you also add gofumpt check in push-check.yml?

gofumpt is from: https://github.com/mvdan/gofumpt

I'm not sure how to use this kind of tool in push-check.yml

@kevwan I will add it into CI. This PR can be merged.

@kevwan
Copy link
Contributor Author

kevwan commented Sep 20, 2021

Thanks @kevwan. Could you also add gofumpt check in push-check.yml?

gofumpt is from: https://github.com/mvdan/gofumpt
I'm not sure how to use this kind of tool in push-check.yml

@kevwan I will add it into CI. This PR can be merged.

Great! I'll learn how you do it. :)

@YangruiEmma YangruiEmma merged commit c634762 into cloudwego:develop Sep 22, 2021
@YangruiEmma
Copy link
Member

Thanks @kevwan. Could you also add gofumpt check in push-check.yml?

gofumpt is from: https://github.com/mvdan/gofumpt
I'm not sure how to use this kind of tool in push-check.yml

@kevwan I will add it into CI. This PR can be merged.

Great! I'll learn how you do it. :)

Add at #150

@kevwan
Copy link
Contributor Author

kevwan commented Sep 23, 2021 •
edited
Loading

Thanks @kevwan. Could you also add gofumpt check in push-check.yml?

gofumpt is from: https://github.com/mvdan/gofumpt
I'm not sure how to use this kind of tool in push-check.yml

@kevwan I will add it into CI. This PR can be merged.

Great! I'll learn how you do it. :)

Add at #150

Thanks! :)

BTW: are gofmt and gofumpt duplicated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsjbd lsjbd lsjbd approved these changes

@YangruiEmma YangruiEmma YangruiEmma approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevwan @YangruiEmma @lsjbd