Use the ui I/O helper to properly serialize diff outputs #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmcelwee
force-pushed
the
amc-diffs-use-ui
branch
from
c106090 to
60e3f8e
Compare
acmcelwee
force-pushed
the
amc-diffs-use-ui
branch
from
60e3f8e to
84d114e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still try to use diffs as a very high-level way to sanity check broad changes across a fairly large blueprints repo. Currently the output is so jumbled together that it's impossible to interpret, when you've got a large number of stacks that are being simultaneously diff'd. The added bonus is that the output becomes a bit more contextually colorized and easier for a human to parse the output.