Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[surfacers.otel] Fix a bug in exporter configuration logic. #654

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[surfacers.otel] Fix a bug in exporter configuration logic. #654

merged 1 commit into from
Dec 19, 2023

Conversation

manugarg
Copy link
Contributor

No description provided.

@manugarg manugarg added this to the v0.13.2 milestone Dec 19, 2023
TaylorMutch
TaylorMutch approved these changes Dec 19, 2023
View reviewed changes
Copy link

@TaylorMutch TaylorMutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I also ran into this issue when trying this out and the config was ignored. This should fix it

@manugarg manugarg merged commit be62d09 into master Dec 19, 2023
9 checks passed
@manugarg manugarg deleted the fix_otel branch December 19, 2023 20:04
@manugarg manugarg added the bug Something isn't working label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaylorMutch TaylorMutch TaylorMutch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.13.2
Development

Successfully merging this pull request may close these issues.
2 participants
@manugarg @TaylorMutch