[labels] Fix a bug in additional labels processing. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional labels will get mixed up if you've multiple targets with the same name (but different labels and ports) because we were using only target names will maintaining additional labels. Also, add a wiki page about current status of additional labels (that I found while working this bug): https://github.com/cloudprober/cloudprober/wiki/Additional-Labels-Rollout-Status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug gets triggered if you're using additional_label with targets that have same name (but different labels or ports) within a probe, e.g. "host_names: www.google.com:80,www.google.com:443".
Additional labels will get mixed up if you've different targets with the same name because so far we were using only target names to maintain additional labels.
To fix this issue, use the same endpoint.Key() function while updating labels for the targets and retrieving them. In all the probes use a consistent argument for AdditionalLabel functions.
Also, add a wiki page about current status of additional labels (that I found while working this bug):
https://github.com/cloudprober/cloudprober/wiki/Additional-Labels-Rollout-Status