initial implementation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Jan 28, 2021
…into feature/initial-implementation
osterman
approved these changes
Jan 28, 2021
aknysh
reviewed
Jan 28, 2021
| ) | ||
|
|
||
| var ( | ||
| version string = "dev" |
There was a problem hiding this comment.
what's the `"dev" version?
Should we change it to prod or something different?
There was a problem hiding this comment.
That's just used locally in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The initial implementation of the
cloudposse/utilsprovider. The first functionality is adata_sourcethat takes a list of maps as input and outputs a single, deep-merged map.why
We have a need to deep merge multiple configuration files from our reference architecture "stacks"