Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to disable codepipeline but allow to keep ecr #210

Merged
merged 4 commits into from
Jan 12, 2023
Merged

option to disable codepipeline but allow to keep ecr #210

merged 4 commits into from
Jan 12, 2023

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Oct 19, 2022 •
edited
Loading

what

why

  • we'd like to not create CodePipeline resources when codepipeline_enabled is false
  • give the option to keep the ECR repo, especially if it already has container images that are pushed without using GitHub Actions or something else

references

@mihaiplesa mihaiplesa requested review from a team as code owners October 19, 2022 13:30
@mihaiplesa mihaiplesa changed the title option to disable codepipeline properly disable codepipeline Oct 19, 2022
@mihaiplesa mihaiplesa mentioned this pull request Oct 19, 2022
Merged
nitrocode
nitrocode reviewed Oct 19, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

@mihaiplesa please fill out the full pr template

@mihaiplesa
Copy link
Contributor Author

@nitrocode done.

@mihaiplesa mihaiplesa requested review from nitrocode and removed request for joe-niland and florian0410 October 19, 2022 14:07
@mihaiplesa mihaiplesa changed the title properly disable codepipeline disable codepipeline but allow to keep ecr Oct 20, 2022
@nitrocode nitrocode requested a review from aknysh October 26, 2022 17:37
@mschfh
Copy link
Contributor

mschfh commented Nov 22, 2022

@nitrocode @aknysh
Can we get this merged please?

@mihaiplesa
Copy link
Contributor Author

Have rebased this, if someone can please re-run tests.

@nitrocode nitrocode removed their request for review December 1, 2022 09:02
@nitrocode
Copy link
Member

I defer to the other maintainers. Thank you for your patience.

@mihaiplesa
Copy link
Contributor Author

@aknysh any chance you could help please?

@mihaiplesa mihaiplesa force-pushed the mplesa-codepipeline-option-to-disable branch from 4cc2090 to 3cef1e7 Compare January 12, 2023 14:31
@mihaiplesa mihaiplesa changed the title disable codepipeline but allow to keep ecr option to disable codepipeline but allow to keep ecr Jan 12, 2023
@aknysh
Copy link
Member

aknysh commented Jan 12, 2023

/test all

aknysh
aknysh reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mihaiplesa

@aknysh aknysh merged commit 78948ae into cloudposse:master Jan 12, 2023
@mihaiplesa mihaiplesa deleted the mplesa-codepipeline-option-to-disable branch August 14, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only create CodePipeline resources when enabled
5 participants
@mihaiplesa @nitrocode @mschfh @aknysh @cloudpossebot