Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Steps so that they always start at 1 #668

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix Steps so that they always start at 1 #668

merged 1 commit into from
Aug 26, 2024

Conversation

osterman
Copy link
Member

what

  • Ensure the <Steps/> component sets the counter context
  • Use the context for <StepNumber/>
  • Fix formatting of philips labs setup
  • Add missing <Steps/> container where necessary

why

  • It was confusing that steps didn't start at 1, if multiple <Steps/> were defined on the page

@osterman osterman merged commit 0070d03 into master Aug 26, 2024
3 checks passed
@osterman osterman deleted the fix-steps branch August 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants