CloudFlare - Invalidate cache on deployment #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runs after deployment
osterman
reviewed
Jun 26, 2018
Makefile
Outdated
| @@ -44,6 +46,7 @@ deps: deps-$(OS) \ | |||
| packages/install/hugo \ | |||
| packages/install/htmltest | |||
| asciinema auth | |||
| npm install -g cloudflare-cli | |||
osterman
reviewed
Jun 26, 2018
Makefile
Outdated
|
|
||
| ## Invalidate CloudFlare cache (all files) | ||
| invalidate-cache: | ||
| cfcli purge \ |
There was a problem hiding this comment.
use @ here so our key is not exposed!
There was a problem hiding this comment.
Also, let's use these instead:
CF_API_KEY # maps to token
CF_API_EMAIL # maps to email
CF_API_DOMAIN # maps to domain
There was a problem hiding this comment.
CF_API_KEY # maps to token CF_API_EMAIL # maps to email CF_API_DOMAIN # maps to domain
* use package.json to manage npm dependencies * use fixed version of cfcli * use invalidate-cache as npm script
osterman
reviewed
Jun 27, 2018
package.json
Outdated
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| "invalidate-cache": "./node_modules/.bin/cfcli purge" |
There was a problem hiding this comment.
Any chance we can just run cfcli purge directly from Makefile?
There was a problem hiding this comment.
Yeap, we can do it by adding ./node_modules/.bin/ to the PATH.
But such kind of commands (that uses dev deps) wrapped into npm scrips.
* remove package.json * install npm packages to global scope * directly call cfcli from make file
… into feature/cloudflare-cache
osterman
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why