Ensure we handle orgs with no users #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Oct 2, 2018
richard-cox
commented
- fixes Can't create an org then space #3093
- When we fetch an org users we check if any user has missing roles collections (there's too many too return inline)
- During this check we assumed the org will always have users
- For the case of a new org there are no users
- When we fetch an org we check if any user is missing any roles collection (there's too many too show) - During this check we assumed the org will always have the users - For the case of a new org there are no users
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3098 +/- ##
=============================================
- Coverage 70.96% 70.95% -0.01%
=============================================
Files 608 608
Lines 26321 26323 +2
Branches 5948 5949 +1
=============================================
Hits 18678 18678
- Misses 7643 7645 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.