Metrics: Add Prometheus Job Information #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3082 +/- ##
=============================================
- Coverage 71.01% 70.96% -0.06%
=============================================
Files 607 608 +1
Lines 26258 26321 +63
Branches 5940 5948 +8
=============================================
+ Hits 18648 18678 +30
- Misses 7610 7643 +33 |
richard-cox
reviewed
Oct 1, 2018
| filter(a => !!a), | ||
| map((targetsData: any) => { | ||
| const mapped = {}; | ||
| if (targetsData.activeTargets) { |
There was a problem hiding this comment.
This is targetsData.data.activeTargets in latest metrics branch, not sure if it's an issue yet on v2-master
richard-cox
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
LGTM - Against v2-master this PR all works fine so we're good to merge. However we'll need to tweak this when the latest metrics (charts and cells) PRs merge
FetchMetricsActionwill need to be updated due to the change in MetricsActions- The format of the metrics response seems to have changed, so
metrics.component.tstargetsData.activeTargetschanged totargetsData.data.activeTargets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the display of which endpoints a metrics endpoint provides metrics for.
Added job name and status from Prometheus