Use consistent icons #2517
Merged
Use consistent icons #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2517 +/- ##
=============================================
+ Coverage 70.42% 70.42% +<.01%
=============================================
Files 594 594
Lines 25132 25135 +3
Branches 5674 5674
=============================================
+ Hits 17698 17701 +3
Misses 7434 7434 |
KlapTrap
suggested changes
Jun 25, 2018
There was a problem hiding this comment.
The no entities message icon isn't consistent. See top level services list and application service instances (might be in other places too).
We should look at the use of subtle on the boolean icon and ensure we're consistent. From Neil: [The subtle flag] Swaps out green/red for subtle colors - i.e not indicating a success or failure but a status
Example:
- Services in the market place use subtle for the yes/no statuses
- Build packs enabled/disable status doesn't use subtle
|
@KlapTrap I've addressed the top-level no-content messages. Will do boolean indicators in another PR. |
nwmac
added
comments-addressed
and removed
needs attention
* v2-master: (63 commits) Postflight script times out if it can not connect Update pgsql_tokens.go Update proxy.env Changes in response to feedback Update `meta_data` field Fix DB schema Configurable backend log level Remove base git package Remove console log Fixed application service instance creation Allow arbitrary suffixes to tag Minor tweaks to the Release pipeline Update CHANGELOG.md minor tweaks trivial changes Changelog wip Update tests to include excluded entities Throw recursive delete failed on cf error wip ...
KlapTrap
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2239, it: