Improve Healthcheck tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a free tcp return by TcpListener, instead of listening on a random port. Read the process output before waiting for the process to exit. Reading the output after WaitForExit caused the healthcheck process to intermittently hang on Console.WriteLine if there was an exception.
|
Hey stefanschneider! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/101878138. |
|
Looks good, thanks! |
stefanschneider
pushed a commit
to stefanschneider/windows_app_lifecycle
that referenced
this pull request
Aug 19, 2016
…k-support [HCFRO-88] Fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a free tcp return by TcpListener, instead of listening on a random
port.
Read the process output before waiting for the process to exit. Reading
the output after WaitForExit caused the healthcheck process to
intermittently hang on Console.WriteLine if there was an exception.
https://www.pivotaltracker.com/story/show/101877652