Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to push classic ASP pages #1

Merged
merged 2 commits into from
Aug 24, 2015
Merged

Add the ability to push classic ASP pages #1

merged 2 commits into from
Aug 24, 2015

Conversation

hashneo
Copy link
Contributor

@hashneo hashneo commented Aug 14, 2015

While I know its outdated technology, many companies including mine will use classic ASP pages. Adding this change lets me push classic ASP applications to the server.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/101255726.

@hashneo
Copy link
Contributor Author

hashneo commented Aug 14, 2015

Another option would be to allow the deploying app to publish a web.config to override the created one?

@mavenraven
Copy link
Contributor

Hey @hashneo, thanks for the PR! Do you have a sample/demo app that you could point us at that we can use to test this change?

@hashneo
Copy link
Contributor Author

hashneo commented Aug 17, 2015

Any simple asp hello world should work fine. You only need to create the single page and push that directory. :-)

Steven
Sent from my iPhone.

On Aug 16, 2015, at 5:55 PM, mavenraven notifications@github.com wrote:

Hey @hashneo, thanks for the PR! Do you have a sample/demo app that you could point us at that we can use to test this change?


Reply to this email directly or view it on GitHub.

@hashneo
Copy link
Contributor Author

hashneo commented Aug 17, 2015

https://github.com/hashneo/asp2dotnet/tree/master/sample

This should work.

Steven
Sent from my iPhone.

On Aug 16, 2015, at 5:55 PM, mavenraven notifications@github.com wrote:

Hey @hashneo, thanks for the PR! Do you have a sample/demo app that you could point us at that we can use to test this change?


Reply to this email directly or view it on GitHub.

@mavenraven
Copy link
Contributor

Thanks! It's on our backlog to take a look at and add tests around. In the meantime, have you signed the CLA? (i.e.

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.
)

@hashneo
Copy link
Contributor Author

hashneo commented Aug 17, 2015

If it's part of cloud foundry then yes.

Steven
Sent from my iPhone.

On Aug 17, 2015, at 11:38 AM, mavenraven notifications@github.com wrote:

Thanks! It's on our backlog to take a look at and add tests around. In the meantime, have you signed the CLA? (i.e.

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.
)


Reply to this email directly or view it on GitHub.

@emalm
Copy link

emalm commented Aug 17, 2015

Dreddbot has its hooks in now, so I will close and reopen this PR, and on the reopen it will do its CLA check.

@emalm emalm closed this Aug 17, 2015
@emalm emalm reopened this Aug 17, 2015
@cfdreddbot
Copy link

Hey hashneo!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@benmoss benmoss merged commit 770ac1e into cloudfoundry-attic:master Aug 24, 2015
@benmoss
Copy link

benmoss commented Aug 24, 2015

@hashneo thanks! we've merged your work in along with a super basic ASP test app.

@hashneo
Copy link
Contributor Author

hashneo commented Aug 24, 2015

Excellent!. Thx.

On Aug 24, 2015, at 10:48 AM, Ben Moss notifications@github.com wrote:

@hashneo https://github.com/hashneo thanks! we've merged your work in along with a super basic ASP test app.


Reply to this email directly or view it on GitHub #1 (comment).

stefanschneider pushed a commit to stefanschneider/windows_app_lifecycle that referenced this pull request Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants