Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make number of replicas configurable in the Helm chart #4647

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Make number of replicas configurable in the Helm chart #4647

merged 1 commit into from
Oct 16, 2020

Conversation

ikapelyukhin
Copy link
Contributor

Description

Makes the number of replicas configurable.

Motivation and Context

Handy for HA setups.

How Has This Been Tested?

Tested with helm upgrade.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

@ikapelyukhin ikapelyukhin requested a review from nwmac October 8, 2020 20:34
@ikapelyukhin
Copy link
Contributor Author

Hmm, should we switch to

maxSurge: 1
maxUnavailable: 0

for the DB pod as well? 🤔

nwmac
nwmac approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 3ea0afe into master Oct 16, 2020
@nwmac nwmac deleted the helm_replica_count branch October 16, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikapelyukhin @nwmac