Add service broker space scope information to service wall list #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Jul 21, 2020
richard-cox
commented
- fixes Show service broker space scope information in service wall list #4458
- ux needs a good review
Codecov Report
@@ Coverage Diff @@
## master #4463 +/- ##
==========================================
- Coverage 58.89% 58.88% -0.02%
==========================================
Files 895 896 +1
Lines 29203 29223 +20
Branches 4219 4218 -1
==========================================
+ Hits 17199 17207 +8
- Misses 12004 12016 +12 |
|
Showing the broker name in the column mirrors what happens on the command-line, and it represents the data about brokers accurately, but it's not very useful to users. When looking at the Marketplace, it's more important to know
Also, because space-scoped brokers have to have unique names even if they're in different spaces, and maybe people are testing out their own version of the broker, you have to add a bunch of noise to the broker name to avoid collisions. For example, mine looks like this: The username is actually the name of the deployer account, which is a GUID! So this ends up pretty ugly when you see the brokername in the output of What would be more useful: Have a column for "Scope", where the value is either "All spaces", or a list of the spaces where that service offering is available. Consolidate offerings that are registered more than once. The user already selects the target space from among those allowed during the configuration workflow... It'll just be a smaller list for space-scoped stuff registered more than once. |
|
@mogul I've made some tweaks following a review and your comments
For 2 & 3 we may rejig these to look nicer given changes required to support v3 of the CF API (both content and requests have changed for all service related items).
I like this idea, but it would be tricky with v2 of the CF API. As it stands we dispatch a request per service broker to fetch broker info for the services on screen. In order to group by scope we'd need to fetch service brokers for all services which would create a scaling issue. It might be easier in v3 but would require some investigation. It may be best to detail this request in a separate issue to be dealt with at the time we update to v3. |
- Show space scope link in app service list (quick access) - Harmonize names (Service, broker, scope, etc) - Fix space scope link in services wall
richard-cox
added a commit
to SUSE/stratos
that referenced
this pull request
Jul 24, 2020
* Improve recent and favourites display (cloudfoundry#4421) * Improve recent and favourites display * Remove debug logging * Remove debug logging/subscription leak * Unit test fix * Tweaks following review * Changes following review - favourite & recent icon changes Co-authored-by: Richard Cox <richard.cox@suse.com> * Add line-height to favourite and recent entity labels (cloudfoundry#4438) - missed out from another PR following review * Autoscaler e2e tests: Give better failure error when the test can't find the scaling row (cloudfoundry#4424) * Improve autoscaler e2e tests * Remove duplicate fail statement * Helm Chart: Remove encryption key volume (cloudfoundry#4355) * Remove encryption key volume * Remove encrpytion key volume migration from config-init job * Improve the logout experience (cloudfoundry#4439) * Add support for including breaking changes in the changelog * Improve the logout experience * Fix unit tests * Add request for version info to github issues template (cloudfoundry#4443) * Merge downstream (cloudfoundry#4441) * Merge src/frontend from downstream * Merge src/jetstream from jetstream * Remove examples/custom-src * Merge deploy from downstream Does not include changes to - deploy/all-in-one/* - deploy/aio-entrypoint.sh - deploy/Dockerfile.all-in-one * Merge build from downstream * Add missing merge items from deploy * Updates to package-lock * Remove fdescribe * Fix e2e core tests * Remove favicon from packages/core/src * Changes following review * Show all favorites for an endpoint favorite if there is only one (cloudfoundry#4440) * Show all favorites for the endpoint favorite if there is only one * Missing changes * Merge downstream - JSON Viewer with dark mode & Header Fixes (cloudfoundry#4444) * Fix json-viewer dark mode * Fix profile page and side nav top position following header diet - Fix side nav top position - Update fix for profile page to also work in non-desktop mode * Fix issues with tests not running if build upload fails (cloudfoundry#4453) * Fix issues with tests not running if build upload fails * Fix script * One more fix for script * Fix white space at start of file * Improve autoscaler e2e logging (cloudfoundry#4456) * Improve autoscaler e2e logging - it looks like the AS returns scaling events 1-2 mins after they occur, which is too late for the test - add additional logging to print out event table data in case of alternative events being raised - fix logging if wait for events times out - add hint in later test that depends on AS scaling event * Ensure only the schedule rule results in scaling events * Fix check-e2e-pr.sh for pr's from other repos (cloudfoundry#4459) - switch from TRAVIS_PULL_REQUEST_SLUG to TRAVIS_REPO_SLUG * Convert Client Secret Input Fields to `password` (cloudfoundry#4455) * Insecure tlsv10 and tlsv11 ciphers in Stratos UI, bsc#1173295 (#411) (cloudfoundry#4460) Co-authored-by: Michal Jura <mjura@users.noreply.github.com> * [Security] Bump codecov from 3.7.0 to 3.7.1 (cloudfoundry#4457) Bumps [codecov](https://github.com/codecov/codecov-node) from 3.7.0 to 3.7.1. **This update includes a security fix.** - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](codecov/codecov-node@v3.7.0...v3.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump lodash from 4.17.15 to 4.17.19 (cloudfoundry#4452) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Convert scripts to nodejs so they work on Windows (cloudfoundry#4462) * Convert scripts to js so they work on Windows * Improve initial developer experience * Fix scss compile on windows * Fix windows build * Use fs not fs-extra where possible (can work without npm install) * Remove gulp * Cleaner fixes for Windows * Reset * Fix whitespace * Address PR feedback Co-authored-by: Neil MacDougall <nmacdougall@suse.com> * Shorten file paths containing `cloudfoundry`/`cloud-foundry` (cloudfoundry#4466) * Fix 'too long' file paths * Fix build issues * Convert scripts to js so they work on Windows * Fix scss compile on windows * Improve initial developer experience * Fix scss compile on windows * Fix windows build * Use fs not fs-extra where possible (can work without npm install) * Remove gulp * Cleaner fixes for Windows * Reset * Fix whitespace * Fix merge Co-authored-by: Neil MacDougall <neil.macdougall@suse.com> Co-authored-by: Neil MacDougall <nmacdougall@suse.com> Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> * Fix log out page when there's a custom log in page (cloudfoundry#4467) * Add service broker space scope information to service wall list (cloudfoundry#4463) * Add service broker space scope information to service wall list * Split out `Space Scope` into it's own `Scope` row/column * Add service broker scope to service instance list (card and table) & app binding list (card) * Fix e2e test * Fix services table, cater for brokers that return 403 * Changes following review - Show space scope link in app service list (quick access) - Harmonize names (Service, broker, scope, etc) - Fix space scope link in services wall * Remove recents and favorites when entities are deleted (cloudfoundry#4431) * Improve recent and favourites display * Remove debug logging * Remove debug logging/subscription leak * Unit test fix * Remove recents and favorites when entities are deleted * Fix merge issues * Fix merge issue * Tidy up and improve following PR feedback * Remove out of date comment * Fixed problem where clear was not working * Check favorite exists before deleting * Version bump and change log (cloudfoundry#4469) * Version bump and change log * Update changelog Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Michal Jura <mjura@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <nmacdougall@suse.com> Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.