Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more store -> core dependencies #4382

Merged
merged 11 commits into from
Jun 23, 2020
Merged

Fix more store -> core dependencies #4382

merged 11 commits into from
Jun 23, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 18, 2020 •
edited
Loading

  • Fix health check import
  • Move sortStringify (only used once)
  • Move NonOptionalKeys - only used once
  • Move KnownKeys
  • Move BrowserStandardEncoder
  • Remove last environment link
  • Move favourite config mapper
  • Remove dependency on StratosScopeStrings

@nwmac nwmac self-assigned this Jun 18, 2020
@richard-cox richard-cox added the needs attention This PR needs attention label Jun 19, 2020
@nwmac nwmac added comments-addressed and removed needs attention This PR needs attention labels Jun 22, 2020
@richard-cox richard-cox merged commit 64b430d into master Jun 23, 2020
@richard-cox richard-cox deleted the store-core-more branch June 23, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
comments-addressed ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwmac @richard-cox