Add support for editing endpoint info #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
suggested changes
Mar 31, 2020
There was a problem hiding this comment.
- Original endpoint name should be excluded from name unique check (edit name, revert back to original and field becomes invalid blocking further progress)
- On a clean form disabling SSL validation does not enable the update button. Same for editing client id/secret
- Adding a client secret of
cf2broke the fetch of all endpoints- Looking at the table it looks like this should be encrypted.. but is stored as
cf2 - refreshing the console results in 'no endpoints' message
- log shows
Unable to decrypt token: ciphertext too short
- Looking at the table it looks like this should be encrypted.. but is stored as
...core/src/features/endpoints/edit-endpoint/edit-endpoint-step/edit-endpoint-step.component.ts
Outdated
Show resolved
Hide resolved
...core/src/shared/components/list/list-types/endpoint/endpoint-card/endpoint-card.component.ts
Outdated
Show resolved
Hide resolved
nwmac
added
comments-addressed
and removed
needs attention
richard-cox
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3640
Fixes #3997
Fixes #3796